Skip to content

Conversation

@Ololoshechkin
Copy link
Collaborator

@Ololoshechkin Ololoshechkin commented Dec 30, 2025

Make sure last successful node is not executed twice when restoring from Persistence checkpoints

Motivation and Context

Previously, if latest node was a successful tool call or any other operation with a side-effect, it was re-executed again although we could've reused the latest successful result. The reason behind that was becaused internally input was required to restore the full subgraph structure.

In this PR, lastInput field of the checkpoints was changed to lastOutput, and resolveEdge() method was used in order to restore the NEXT node with the correct input instead of the current node.

Breaking Changes

In checkpoints structure, lastInput field was changed to lastOutput


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

@Rizzen
Copy link
Member

Rizzen commented Jan 2, 2026

That sounds reasonable, but there are a bunch of tests to fix

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Qodana for JVM

1256 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 1236
Missing KDoc for public API declaration 🔶 Warning 20
@@ Code coverage @@
+ 72% total lines covered
18140 lines analyzed, 13076 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants