Skip to content

Conversation

@sdubov
Copy link
Contributor

@sdubov sdubov commented Dec 16, 2025

KG-622.

  • Change the default span processor for OTel from Simple to Batch span processor implementation;
  • Add logic to wait for flushing all spans when agent is finished;
  • Update tests.

Motivation and Context

Update the default span processor for open telemetry to follow the common standards.

Breaking Changes

No


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

@sdubov sdubov requested a review from Rizzen December 16, 2025 10:39
@sdubov sdubov self-assigned this Dec 16, 2025
@sdubov sdubov added the enhancement New feature or request label Dec 16, 2025
- Change the default span processor for OTel from Simple to Batch span processor implementation;
- Add logic to wait for flushing all spans when agent is finished;
- Update tests.
@github-actions
Copy link

Qodana for JVM

1205 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 1185
Missing KDoc for public API declaration 🔶 Warning 20
@@ Code coverage @@
+ 73% total lines covered
17354 lines analyzed, 12677 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Comment on lines +296 to +297
assertTrue(collectedSpansOnAgentClosing > 0)
assertEquals(collectedSpansOnAgentClosing, mockExporter.collectedSpans.size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s use awaitility to help us avoid any potential flakiness. It’s always better to be safe than sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants