Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect Web Build Command #5100

Closed
wants to merge 2 commits into from

Conversation

soleil-colza
Copy link

@soleil-colza soleil-colza commented Jul 17, 2024

Overview

Corrected the Web build command for Jetsnack and Imageviewer. The previously documented command ./gradlew :web:wasmJsRun resulted in a build failure due to the project 'web' not being found. The correct command is ./gradlew :composeApp:wasmJsRun . This update ensures accurate instructions for building the Web component.

Example of the error message when using the incorrect command:

Cannot locate tasks that match ':web:wasmJsRun' as project 'web' not found in root project 'KotlinProject'.

Testing

  • Confirmed the fixed command ./gradlew :composeApp:wasmJsRun successfully starts up the localhost and displays the contents.

Section - Subsection

Web
Build System
(prerelease fix) Corrected the Web build command from ./gradlew :web:wasmJsRun to ./gradlew :composeApp:wasmJsRun, fixing a bug introduced in a prerelease version. This ensures the correct project is targeted during the build process.

Section - Subsection

N/A

@soleil-colza soleil-colza marked this pull request as ready for review July 17, 2024 05:08
@pjBooms pjBooms self-requested a review July 17, 2024 17:41
Copy link
Collaborator

@pjBooms pjBooms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct command for Jetsnack is still ./gradlew :web:wasmJsRun (there is no composeApp module for this example).

The correct command for Imageviewer is ./gradlew :webApp:wasmJsRun

@pjBooms
Copy link
Collaborator

pjBooms commented Jul 26, 2024

Fixed in #5106

@pjBooms pjBooms closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants