[resources] Add image bitmap/xml/svg bytearray converters to the corresponding source sets. #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
requested changes
Jul 18, 2024
...nts/resources/library/src/commonMain/kotlin/org/jetbrains/compose/resources/ImageDecoders.kt
Show resolved
Hide resolved
...esources/library/src/skikoMain/kotlin/org/jetbrains/compose/resources/ImageDecoders.skiko.kt
Show resolved
Hide resolved
|
It doesn't fix it completely, until https://android-review.googlesource.com/c/platform/frameworks/support/+/3174259 is merged. Let's change to "Partially fixes" |
|
Maybe we can add the method to the library at the moment? And deprecate it when the platform implementation is merged |
Looks good to me, let's do this way |
terrakok
force-pushed
the
k.tskh/img-decoders
branch
from
ace9e03
to
8c6d2e9
Compare
terrakok
force-pushed
the
k.tskh/img-decoders
branch
from
8c6d2e9
to
5332ee1
Compare
terrakok
changed the title
MatkovIvan
approved these changes
Jul 24, 2024
igordmn
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds methods to convert a bitmap bytearray to the ImageBitmap and a vector XML content bytearray to the ImageVector in the common code. And the same for an SVG files on non-android targets.
Fixes https://youtrack.jetbrains.com/issue/CMP-3869
Fixes https://youtrack.jetbrains.com/issue/CMP-4925
Release Notes
Features - Resources
Bitmap ByteArray as ImageVectorandXML ByteArray as ImageVectorin the common code andSVG ByteArray as Painterin the non-android code