Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using SwingPanel in Compose for Desktop, it blocks PopupWindow #3353

Closed
changhexuefei opened this issue Jul 15, 2023 · 3 comments
Closed

When using SwingPanel in Compose for Desktop, it blocks PopupWindow #3353

changhexuefei opened this issue Jul 15, 2023 · 3 comments
Assignees
@MatkovIvan
Labels
bug Something isn't working

Comments

@changhexuefei
Copy link

Describe the bug
When using SwingPanel in Compose for Desktop, it blocks PopupWindow

Affected platforms
Select one of the platforms below:

  • Desktop

Versions

  • Kotlin version*: 1.8.10
  • Compose Multiplatform version*: 1.4.0
  • OS version(s)* (required for Desktop and iOS issues): Windows 11
  • OS architecture (x86 or arm64): 64
  • JDK (for desktop issues): jdk16
problem
@changhexuefei changhexuefei added bug Something isn't working submitted labels Jul 15, 2023
@changhexuefei
Copy link
Author

The correct display should be like this
correct

@pjBooms pjBooms removed the submitted label Jul 17, 2023
@pjBooms
Copy link
Collaborator

pjBooms commented Jul 17, 2023

It seems to be related to #2926

@igordmn igordmn assigned Walingar and unassigned igordmn Jul 17, 2023
@MatkovIvan MatkovIvan mentioned this issue Nov 24, 2023
Merged
@MatkovIvan MatkovIvan assigned MatkovIvan and unassigned Walingar Nov 24, 2023
MatkovIvan added a commit to JetBrains/compose-multiplatform-core that referenced this issue Dec 15, 2023
@MatkovIvan
Proper clipping of SwingPanel interop (#915)
9751714 
## Proposed Changes

- Adopt an approach that we're using for iOS - using custom blending to
respect clip/shape modifiers and overlapped drawings.
- Fix bounds in window calculation - it should work properly inside
scaled content now.

## Testing

The new behavior is under a feature flag, so you can test it by setting
system property:

```kt
System.setProperty("compose.interop.blending", "true")
```

Currently it supports Metal (macOS), Direct3D (Windows) (requires
JetBrains/skiko#837), and off-screen rendering
(might be enable by another feature flag:
`compose.swing.render.on.graphics`)

### Clipping

```kt
SwingPanel(
    modifier = Modifier.clip(RoundedCornerShape(6.dp))
    ...
)
```
<img width="262" alt="image"
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/a03926f5-8977-4530-8894-d84aedfd5939">

### Overlapping

```kt
Box(modifier = Modifier.fillMaxSize()) {
    SwingPanel(factory = {
        JPanel().also { panel ->
            panel.background = java.awt.Color.red
            panel.add(JButton().also { button ->
                button.text = "JButton"
            })
        }
    })
    Snackbar(
        action = { Button(onClick = {}) { Text("OK") } },
        modifier = Modifier.padding(8.dp).align(Alignment.BottomCenter),
    ) {
        Text("Snackbar")
    }
    Popup(alignment = Alignment.Center) {
        Box(
            modifier = Modifier.size(200.dp, 100.dp).background(Gray),
            contentAlignment = Alignment.Center,
        ) {

            Text("Popup")
        }

    }
}
```
<img width="592" alt="Screenshot 2023-11-27 at 13 57 43"
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/dda1f2d6-6a1e-456c-8763-46a82d9562a8">


## Issues Fixed

Fixes JetBrains/compose-multiplatform#3823
Fixes JetBrains/compose-multiplatform#3739
Fixes JetBrains/compose-multiplatform#3353
Fixes JetBrains/compose-multiplatform#3474
@MatkovIvan MatkovIvan mentioned this issue Feb 22, 2024
Closed
@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatkovIvan MatkovIvan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@MatkovIvan @pjBooms @igordmn @changhexuefei @Walingar @okushnikov