Add a SystemThemeObserver implementation for wasmJs #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igordmn any chance this gets into 1.6? |
eymar
reviewed
Feb 6, 2024
compose/ui/ui/src/wasmJsMain/kotlin/androidx/compose/ui/window/SystemThemeObserver.wasm.kt
Outdated
Show resolved
Hide resolved
yes, it will get into 1.6 |
|
this change doesn't affect iOS, so Failing iOS unit tests is not a blocker here. |
lppedd
reviewed
Feb 14, 2024
| // supported by all browsers since 2015 | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/Window/matchMedia | ||
| @JsFun("() => window.matchMedia != undefined") |
There was a problem hiding this comment.
Question out of curiosity: why was this JsFun hack used instead of accessing the window global directly?
There was a problem hiding this comment.
I believe I did that because the window global's matchMedia isn't nullable, and this check is to see if it exists, which I think wouldn't go well with using the global if it actually didn't exist (although I didn't actually test to see if it would crash).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
SystemThemeObserverfor wasmJsTesting
Test: Built locally and used with a wasmJs compose app, and observed that dark mode was set correctly
Google CLA
Done