Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper clipping of
SwingPanel
interop #915Proper clipping of
SwingPanel
interop #915Changes from all commits
788128d
e04296f
40aee2b
b2622cb
7493270
2424eee
0284d5e
a54f9bb
129f55f
16214cd
5b3c3a5
e007659
469f21f
2c57542
8722920
1dc991e
8456503
91f5d25
a9d30dd
bae2c0e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to allow changing these settings at runtime? If not, I suggest reading them once and storing the values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's existing behaviour, I don't want to introduce new restrictions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Alexander, we use so many hacks for
transparency
that we can easily break the behavior in the future.I tested main variations on Windows/macOs - it works, but to be safe, let's write
java.awt.Robot
screenshot tests for different OS'es, as we wrote them in Skiko (look atSkiaLayerTest
).Disable it for now, as we should run them only on CI. I will configure it later myself.
We can merge the PR now to receive feedback earlier, but If we agree that we can/should write the tests, we should write them before the 1.6.0 release (please, create a task).
Even if Robot tests can be flaky and it is hard to run them locally, they are very useful.
To write tests for transparency, we can place an opaque window behind a transparent window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://youtrack.jetbrains.com/issue/COMPOSE-672/Test-Proper-clipping-of-SwingPanel-interop#focus=Comments-27-8631837.0-0