Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIViewController interop #882

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Conversation

elijah-semyonov
Copy link

@elijah-semyonov elijah-semyonov commented Oct 19, 2023

Proposed Changes

Add API for embedding UIViewControllers for cases, where UIView-based API is not available (like SwiftUI integration via UIHostingController, UITabBarController, UINavigationController, etc.).

Testing

Test: check "SwiftUI interop example" in Demo.

Screenshot 2023-10-19 at 15 18 16

API Changes

New iOS source set function UIKitViewController for embedding native UIViewController's similar to UIKitView

@elijah-semyonov elijah-semyonov marked this pull request as draft October 19, 2023 13:20
Copy link

@dima-avdeev-jb dima-avdeev-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@elijah-semyonov elijah-semyonov marked this pull request as ready for review November 20, 2023 12:40
@elijah-semyonov elijah-semyonov merged commit baa222d into jb-main Nov 20, 2023
3 checks passed
@elijah-semyonov elijah-semyonov deleted the es/uikitviewcontroller-interop branch November 20, 2023 12:41
mazunin-v-jb pushed a commit that referenced this pull request Dec 7, 2023
## Proposed Changes

Add API for embedding UIViewControllers for cases, where UIView-based
API is not available (like SwiftUI integration via UIHostingController,
UITabBarController, UINavigationController, etc.).

## Testing

Test: check "SwiftUI interop example" in Demo.

<img width="424" alt="Screenshot 2023-10-19 at 15 18 16"
src="https://github.com/JetBrains/compose-multiplatform-core/assets/4167681/0e7e23b5-687f-40a0-a574-cff48e951acb">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants