reproduce and reminder about iOS SelectionContainer bug #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
requested changes
Oct 11, 2023
| @@ -24,5 +24,6 @@ val IosBugs = Screen.Selection( | |||
| KeyboardEmptyWhiteSpace, | |||
| KeyboardPasswordType, | |||
| UIKitRenderSync, | |||
| DispatchersMainDelayCheck | |||
| DispatchersMainDelayCheck, | |||
| SelectionContainer, | |||
There was a problem hiding this comment.
I guess we need to add such tests into common code. This list was made to call API from uikitMain source set, but now it's used not for this purpose
There was a problem hiding this comment.
Done!
Moved to commonMain "BugReproducers" section.
Also moved all bug reproducers to separate package.
MatkovIvan
approved these changes
Oct 12, 2023
…ainer # Conflicts: # compose/mpp/demo/src/uikitMain/kotlin/bugs/IosBugs.kt
dima-avdeev-jb
deleted the
dima.avdeev/COMPOSE-478-iOS-SelectionContainer
branch
mazunin-v-jb
pushed a commit
that referenced
this pull request
Dec 7, 2023
Made reproducer of a bug JetBrains/compose-multiplatform#3718 This bug should be fixed after merging newer version of androidx-main to jb-main branch. Added TODO comment to check and close related issues after that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made reproducer of a bug JetBrains/compose-multiplatform#3718
This bug should be fixed after merging newer version of androidx-main to jb-main branch.
Added TODO comment to check and close related issues after that.