Avoid calling Window.setVisible(true) on every AwtWindow
recomposition
#863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're calling
Window.isVisible = true
on everyAwtWindow
recomposition, which has the unfortunate side-effect of callingWindow.toFront()
.Proposed Changes
Replace the
SideEffect
+DisposableEffect
that shows/hides the window with just oneTesting
Test: Added two unit tests: one to test that a window isn't brought to front when recomposed, and another (per @igordmn's request) that rendering in the parent window isn't blocked by a modal
DialogWindow
.Issues Fixed
Fixes: JetBrains/compose-multiplatform#2994