All Popup overloads call dismiss on Esc key by default
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
force-pushed
the
ivan.matkov/owner-key-events
branch
from
2569705
to
9be340c
Compare
igordmn
reviewed
Jul 26, 2023
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Popup.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Popup.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaBasedOwner.skiko.kt
Show resolved
Hide resolved
MatkovIvan
force-pushed
the
ivan.matkov/owner-key-events
branch
from
9be340c
to
cc776f2
Compare
igordmn
approved these changes
Jul 27, 2023
This was referenced Jul 28, 2023
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
…` key by default (#712) * Expose root modifier instead of key events * Use only one element for key input * Handle Esc by default in existing Popup * Create onKeyEvent modifier only if needed * Revert EmptySemanticsElement * Remove handling Esc key explicitly * Add dismiss Popup by Esc tests * Move dismissOnEsc to separate modifier
igordmn
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Expose root modifier instead of key events * Use only one element for key input * Handle Esc by default in existing Popup * Create onKeyEvent modifier only if needed * Revert EmptySemanticsElement * Remove handling Esc key explicitly * Add dismiss Popup by Esc tests * Move dismissOnEsc to separate modifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Popupto match default behaviour - It callsonDismissRequestonEsckey by default now.SkiaBasedOwner. It allows not only optimize modifier count, but also applying semantics into root nodeKeyInputElementinternalto reduce modifier count on pair keyboard eventsTesting
Test: create
Popupvia old overload, it closes byEscnow. Consume event to prevent this