cfw: Workaround ComposeWindow multiple event listeners on resize #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the resize function in ComposeWindow.js.kt to avoid multiple event listeners being applied on every resize event. Implemented via cloning the old canvas and replacing it with the new one. This is a workaround solution and a better strategy to fix this in skiko will be considered in the future.
eymar
changed the title
MatkovIvan
approved these changes
Jul 19, 2023
MatkovIvan
pushed a commit
that referenced
this pull request
Sep 10, 2024
Test: GH workflows Change-Id: I424b6753a3421281a4bc429287b0b517dc68ae0d This is an imported pull request from androidx#692. Resolves #692 Github-Pr-Head-Sha: a188d2b GitOrigin-RevId: 2bcb47d Change-Id: Ibff04bff528238ccf0ecbe5433097c64278a1d86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the resize function in ComposeWindow.js.kt to avoid multiple event listeners being applied on every resize event. Implemented via cloning the old canvas and replacing it with the new one. This is a workaround solution and a better strategy to fix this in skiko will be considered in the future.
P.S. I'd like it to be inclided in 1.5.0-beta