CfW: let ComposeWindow accept a custom canvas id (html canvas element id) #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… id) It upstreams the change from wasm-main branch to jb-main branch
dima-avdeev-jb
approved these changes
Jul 7, 2023
compose/ui/ui/src/jsWasmMain/kotlin/androidx/compose/ui/window/ComposeWindow.js.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/jsWasmMain/kotlin/androidx/compose/ui/window/ComposeWindow.js.kt
Show resolved
Hide resolved
dima-avdeev-jb
approved these changes
Jul 7, 2023
Walingar
pushed a commit
to Walingar/androidx
that referenced
this pull request
Jul 11, 2023
… id) (JetBrains#626) * CfW: let ComposeWindow accept a custom canvas id (html canvas element id) It upstreams the change from wasm-main branch to jb-main branch * PR review fixed
mazunin-v-jb
pushed a commit
that referenced
this pull request
Jul 11, 2023
… id) (#626) * CfW: let ComposeWindow accept a custom canvas id (html canvas element id) It upstreams the change from wasm-main branch to jb-main branch * PR review fixed
eymar
pushed a commit
that referenced
this pull request
Dec 18, 2023
## Proposed Changes - Update Revved up by Develocity badge ## Testing Test: Describe how you tested your changes. Note that this line (with `Test:`) is required, your PR will not build without it! ## Issues Fixed Fixes: [Optional] The bug on [https://issuetracker.google.com](https://issuetracker.google.com) being fixed This is an imported pull request from androidx#626. Resolves #626 Github-Pr-Head-Sha: 8b2718b GitOrigin-RevId: f5ff0ef Change-Id: I4cd12870cb403e858f249054bbc7500a45ae627a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "upstreams" the changes from wasm-main to jb-main:
The canvas element id was hardcoded. Now it's possible to set any canvas id.
Also, the canvas will automatically set its size to the browser window and it will resize automicatically. It's the default behaviour, that can be changed by a user.