Use Segoe UI on windows by default #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
approved these changes
May 9, 2023
igordmn
pushed a commit
that referenced
this pull request
Jun 23, 2023
When generating an `equals` method from `commonMain` code, Studio suggests the usage of `if (other == null || this::class != other::class) return false` instead of `if (javaClass != other?.javaClass) return false`. I'm just calling this out because of the following line: https://github.com/androidx/androidx/blob/88877d72f62df51fc9dd040da322c9046aa81f67/paging/paging-common/src/main/kotlin/androidx/paging/TransformablePage.kt#L90-L93 Test: ./gradlew test connectedCheck Bug: 270612487 This is an imported pull request from androidx#557. Resolves #557 Github-Pr-Head-Sha: 46f0a47 GitOrigin-RevId: 6174fc5 Change-Id: I3cea473d5c722a3f4e4a212e36db253de976670e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Segoe UI is the Windows system font, so try it first.
See https://learn.microsoft.com/en-us/windows/win32/uxguide/vis-fonts
Testing
Test: Run
mppon WindowsIssues Fixed
Fixes JetBrains/compose-multiplatform#2985