feat: EXPOSED-45 Support single statement UPSERT #1743

bog-walk · 2023-05-20T02:15:01Z

Add functionality for INSERT or UPDATE command.

MySQL, PostgreSQL, and SQLite use their own specific implementations, while the other dialects use the standard MERGE USING statement with aliases and a derived table.

Accepts optional user-defined key columns to determine the conflict condition. If none are provided, the primary key is used. If there is no primary key, the first unique index is used. If there are no unique indices, each dialect handles differently, but any documentation should probably strongly advise that keys are defined to avoid unexpected results.

Accepts an optional WHERE clause, as well as user-defined update assignments if update behaviour differs from insert behaviour. Column expressions, defaults, and subqueries are also enabled if the individual dialect allows them.

Current caveats:

Dialects that use MERGE require that the key used in the ON clause is present in the derived table. So if an IntIdTable is used e.g., usually the user doesn't have to manually specify the next id, but upsert will fail unless the id is provided.

Vendor-specific features not currently covered:

[SQLite] Should be able to chain multiple On CONFLICT causes together.
[SQLite, PostgreSQL] User-defined update expressions & WHERE clause should be able to access insert values using excluded. identifier. Workaround is to reference the value that would have been inserted directly.
[Oracle, SQLServer, H2] Technically do allow WHERE clause, but multiple and specific to either WHEN [NOT] MATCH THEN clause (Oracle differs in placement too).

Plan:

Submit a second PR for batch upsert, unless advised to push them together.
Submit a PR that addresses possible overlap with current implementation of REPLACE (at least in PostgreSQL) & update API docs (the 2 queries are very similar but not equivalent).
Add WHERE clause functionality to MERGE implementations.

Add functionality for insert or update (upsert) command in all dialects. MySQL, PostgreSQL, and SQLite use their own insert syntax, while the other dialects use the standard merge syntax. The implementation accepts optional user-defined conflict key columns, as well as a single update where clause. It also allows update expressions to be provided if they need to be different from the provided insert values. Column expressions, defaults, and subqueries are also enabled if the individual dialect allows them.

bog-walk · 2023-05-20T02:49:38Z

exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/vendors/OracleDialect.kt

+        val (leftReserved, rightReserved) = " USING " to " ON "
+        val leftBoundary = statement.indexOf(leftReserved) + leftReserved.length
+        val rightBoundary = statement.indexOf(rightReserved)
+        return statement.replaceRange(leftBoundary, rightBoundary, dualTable)


A technicality, but I'm not entirely sure about this choice. If anyone has a cleaner idea of how to replace this chunk in the middle of a statement, I'm open to alternatives. The other way I considered was:

return statement.replaceAfter(" USING ", dualTable) + statement.replaceBefore(" ON ", "")

it's ok to make it this way

e5l · 2023-05-30T08:03:04Z

exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/UpsertStatement.kt

+import org.jetbrains.exposed.sql.*
+import org.jetbrains.exposed.sql.vendors.*
+
+open class UpsertStatement<Key : Any>(


please add KDoc

e5l

lgtm

e5l

lgtm

red-avtovo · 2023-09-19T15:46:36Z

Some examples or a doc page would be much appreciated.
This page covers only one operation, while I'm trying to figure out how to refer to the new value that was intended to be inserted

bog-walk requested review from Tapac, e5l and joc-a May 20, 2023 02:15

This was linked to issues May 20, 2023

updateOrInsert Method #1509

Closed

Support merge statement #1441

Closed

Support upsert functionality #167

Closed

bog-walk commented May 20, 2023

View reviewed changes

Extract excluding H2 v1 condition check function

4604aa5

e5l reviewed May 30, 2023

View reviewed changes

e5l approved these changes May 30, 2023

View reviewed changes

Add KDocs to UpsertStatement class

0ddddf3

bog-walk requested a review from e5l May 30, 2023 12:58

bog-walk mentioned this pull request May 30, 2023

fix: EXPOSED-49 Replace statement defined as upsert statement #1747

Merged

e5l approved these changes May 31, 2023

View reviewed changes

bog-walk merged commit c0a8af0 into master May 31, 2023

bog-walk deleted the bog-walk/support-single-upsert branch May 31, 2023 10:38

cwrau mentioned this pull request Jul 25, 2023

Any plans for a new release? #1480

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: EXPOSED-45 Support single statement UPSERT #1743

feat: EXPOSED-45 Support single statement UPSERT #1743

bog-walk commented May 20, 2023

bog-walk May 20, 2023

e5l May 30, 2023

e5l May 30, 2023

bog-walk May 30, 2023

e5l left a comment

e5l left a comment

red-avtovo commented Sep 19, 2023

feat: EXPOSED-45 Support single statement UPSERT #1743

feat: EXPOSED-45 Support single statement UPSERT #1743

Conversation

bog-walk commented May 20, 2023

bog-walk May 20, 2023

Choose a reason for hiding this comment

e5l May 30, 2023

Choose a reason for hiding this comment

e5l May 30, 2023

Choose a reason for hiding this comment

bog-walk May 30, 2023

Choose a reason for hiding this comment

e5l left a comment

Choose a reason for hiding this comment

e5l left a comment

Choose a reason for hiding this comment

red-avtovo commented Sep 19, 2023