[LKPR-0] chore: recover 4 code-review patterns into lorekeeper-code-reviewer - #343
Merged
Merged
Conversation
…eviewer Recovered from stale stashes (LKPR-124/128/130/105 era) that never landed: - Svelte fetch without res.ok → silent HTTP error swallowing (MAJOR) - Processor must clamp unbounded pagination params (MAJOR) - Overlay component added without component test when siblings have one (BLOCKER) - Dashboard route dropping MCP handler response fields (MAJOR) Appended as blocker-patterns.md sections 25-28, added 4 red-flag bullets, bumped skill 1.20.0 → 1.21.0.
Contributor
Coverage report
The report is also available in the GitHub Actions job summary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Recovers 4 code-review patterns that were sitting in stale git stashes (from the LKPR-124/128/130/105 era) and never landed on main. The
lorekeeper-code-reviewerskill had since evolved to 1.20.0, so these were re-applied against current content, not popped blind.Appended to
references/blocker-patterns.mdas sections 25–28:fetch(...)withoutres.ok→ silent HTTP error swallowingAlso: 4 matching quick-scan bullets in SKILL.md 'Repo-Specific Red Flags', pattern count 24 → 28, version 1.20.0 → 1.21.0.
Why
Real BLOCKER/MAJOR signal from past reviews that would otherwise be lost when the stashes were dropped. Now encoded durably.
Notes
SKILL.md stays lean at 7290/8000 chars. Skill-only change, no
src/touched.blocker-patterns.mdhas two## 15.sections (lines 201 & 225) — a numbering collision that predates this PR. Left alone to keep this PR focused; flagging for a separate renumber pass.