support change global baseUrl at runtime #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,8 +146,8 @@ public void accept(Throwable throwable) throws Exception { | |||
| findViewById(R.id.bt_request3).setOnClickListener(new View.OnClickListener() { | |||
| @Override | |||
| public void onClick(View v) { | |||
| String url = RetrofitUrlManager.getInstance().fetchDomain(DOUBAN_DOMAIN_NAME); | |||
| if (!url.equals(mUrl3.getText().toString())) { //可以在 App 运行时随意切换某个接口的 BaseUrl | |||
| HttpUrl url = RetrofitUrlManager.getInstance().fetchDomain(GANK_DOMAIN_NAME); | |||
There was a problem hiding this comment.
fetchDomain(DOUBAN_DOMAIN_NAME);
| String url = RetrofitUrlManager.getInstance().fetchDomain(GITHUB_DOMAIN_NAME); | ||
| if (!url.equals(mUrl1.getText().toString())) { //可以在 App 运行时随意切换某个接口的 BaseUrl | ||
| HttpUrl url = RetrofitUrlManager.getInstance().fetchDomain(GITHUB_DOMAIN_NAME); | ||
| if (url == null || !url.equals(HttpUrl.parse(mUrl1.getText().toString()))) { //可以在 App 运行时随意切换某个接口的 BaseUrl |
There was a problem hiding this comment.
if (url == null || !url.toString().equals(mUrl1.getText().toString())) 少HttpUrl.parse一次节约性能
| * 存放 Domain 的映射关系 | ||
| * | ||
| * @param domainName | ||
| * @param domainUrl | ||
| */ | ||
| public void putDomain(String domainName, String domainUrl) { | ||
| synchronized (mDomainNameHub) { | ||
| mDomainNameHub.put(domainName, domainUrl); | ||
| mDomainNameHub.put(domainName, mUrlParser.parseUrl(domainUrl)); |
There was a problem hiding this comment.
mDomainNameHub.put(domainName, Utils.checkUrl(domainUrl));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、先判断是否有domain header，然后判断是否有设置全局url，如果都没有返回原来的request；
2、单独设置的domain header会覆盖全局的url；
3、putDomain的时候就解析url；如果url无效就抛出异常；