-
Notifications
You must be signed in to change notification settings - Fork 11
Description
Hi!
It seems to me that the implementation of the SOPHE grid given in
Line 787 in b9b76e4
| def sophegrid(octants,maxphi,size): |
differs from that given in EASYSPIN, see
https://github.com/StollLab/EasySpin/blob/5c396b941b9216377d8507a0187ef378dfaeaf35/easyspin/sphgrid.m#L44C30-L44C30
I implemented the SOPHE grid just as is done in EASYSPIN in Julia and I noticed the following differences with the Python implementation.
- The weights of the points in the grid are bunched towards the XZ plane rather than towards the pole of the sphere
- The density and sparsity of points close to the XZ plane is much less homogeneous than for the rest of the octant
All calculations are done for one octant, a maximum phi of pi/2 and 100 points in theta. Left is Python, right is EASYSPIN in Julia. The colormap maps to the weight of the point. The sum of weights does add up to 4pi.
It is not 100% obvious to me what the difference could be between implementations since the source for both seems equivalent. Still I thought it was useful to shine light on this.
Best wishes,
Abraham