Fix extra file watcher events causing unnecessary Node.js restarts #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the framework
FileSystemWatchertype to watch for file changes and restart Node.js when they occur.FileSystemWatcheris known to fire extra events on windows. To work around this, we were stoppingFileSystemWatcherwhen we received an event:Javascript.NodeJS/src/NodeJS/NodeJSServiceImplementations/OutOfProcess/OutOfProcessNodeJSService.cs
Line 593 in 3f5eb53
and restarting it only after moving to a new Node.js process:
Javascript.NodeJS/src/NodeJS/NodeJSServiceImplementations/OutOfProcess/OutOfProcessNodeJSService.cs
Line 461 in 3f5eb53
After 144, moving to a new process sped up to the point where we would sometimes:
Unnecessary Node.js restarts caused tests to fail (e.g. first failure has 7 "file changed" logs when there should only be 5).
This PR fixes the issue by debouncing file changed events.