Skip to content

Conversation

@JeremyTCD
Copy link
Member

@JeremyTCD JeremyTCD commented Feb 24, 2021

  • HttpNodeJSService now logs the endpoint it connects to Node.js on. This'll help with troubleshooting socket permission issues.
  • Added OutOfProcessNodeJSServiceOptions.NumProcessRetries. You can now retry invocations in new processes. Details:
    /// <summary>
    /// <para>The number of times we create a new NodeJS process to retry an invocation.</para>
    /// <para>Invocations are retried <see cref="NumRetries"/> times in the existing NodeJS process. Once <b>existing process retries</b> are exhausted,
    /// if any <b>process retries</b> remain, a new NodeJS process is created and invocations are retried <see cref="NumRetries"/> times in the new process.</para>
    /// <para>For example, consider the situation where <see cref="NumRetries"/> and this value are both 1. An invocation is first tried in the existing process.
    /// If it fails it is retried in the same process. If it fails again, a new process is created and the invocation is retried there once. In total, the
    /// invocation is attempted 3 times.</para>
    /// <para>If set to a negative value, new NodeJS processes are recreated for retries indefinitely.</para>
    /// <para>If the module source of an invocation is an unseekable stream, the invocation is not retried.
    /// If you require retries for such streams, copy their contents to a <see cref="MemoryStream"/>.</para>
    /// <para>Defaults to 1.</para>
    /// </summary>
    public int NumProcessRetries { get; set; } = 1;

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #101 (ba97830) into master (3d17497) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   97.05%   97.08%   +0.02%     
==========================================
  Files          24       24              
  Lines         815      822       +7     
==========================================
+ Hits          791      798       +7     
  Misses         24       24              
Impacted Files Coverage Δ
src/NodeJS/NodeJSServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...ementations/OutOfProcess/Http/HttpClientService.cs 100.00% <100.00%> (ø)
...ementations/OutOfProcess/Http/HttpNodeJSService.cs 97.26% <100.00%> (-0.31%) ⬇️
...ementations/OutOfProcess/Http/InvocationContent.cs 100.00% <100.00%> (ø)
...ntations/OutOfProcess/OutOfProcessNodeJSService.cs 99.18% <100.00%> (+0.04%) ⬆️
...s/OutOfProcess/OutOfProcessNodeJSServiceOptions.cs 100.00% <100.00%> (ø)
src/NodeJS/StaticNodeJSService.cs 100.00% <100.00%> (ø)
src/NodeJS/Strings.Designer.cs 78.78% <100.00%> (+1.36%) ⬆️
src/NodeJS/Utils/JsonService.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d17497...7e31ac8. Read the comment docs.

@JeremyTCD JeremyTCD merged commit b96c2f9 into master Feb 24, 2021
@JeremyTCD JeremyTCD deleted the improve-robustness branch February 24, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant