Skip to content

Update preprocessor directives to use NET5_0_OR_GREATER to support .net 6 #127

@samcic

Description

@samcic

In various parts of the codebase, e.g. HttpNodeJSService.cs, we see preprocessor directives like

#if NETCOREAPP3_1 || NET5_0
...
#endif

Now that .net 6 is out, would the following make more sense?

#if NETCOREAPP3_1 || NET5_0_OR_GREATER
...
#endif

From what I can tell, using this library in a .net 6 app doesn't allow for the use of HTTP 2.0, for example.

Happy to contribute a PR if it's easier to get this change in, just let me know!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions