Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for promote/demote channel member to/from admin + Fix serialization bug + Update limits for member invite based on latest zoom api docs #390

Merged
merged 17 commits into from
Feb 23, 2025

Conversation

iarsslen
Copy link
Contributor

@iarsslen iarsslen commented Feb 16, 2025

Added support for promote/demote member + Fixed chat mention bug
Fixed Invite member model (api got updated)
Updated limits for channel invite, because zoom api got updated
Upgraded nugets

Arsslen Idadi added 2 commits February 16, 2025 16:37
Fixed Invite member model (api got updated)
Updated limits for channel invite, because zoom api got updated
@iarsslen iarsslen changed the title Improvements Improvements & Bug fixes Feb 16, 2025
@Jericho
Copy link
Owner

Jericho commented Feb 17, 2025

Thanks for submitting this PR. Give me some time to review.

The title of your PR will eventually be included in the release notes therefore it's important to be as clear as possible and I'm afraid "Improvements" is quite vague. I thought the title of #389 was much clearer. Speaking of #389, I'm curious: why did you close it?

Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for taking the time to submit this PR.

@iarsslen iarsslen changed the title Improvements & Bug fixes Added support for promote/demote channel member to/from admin + Fix serialization bug + Update limits for member invite based on latest zoom api docs Feb 17, 2025
Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. Just add the DebuggerBrowsable to the two model properties we want to hide from developers and this will be ready to be merged.

Thanks again for doing this.

Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thank you for your contribution.

@Jericho Jericho merged commit 378057f into Jericho:develop Feb 23, 2025
2 checks passed
Jericho added a commit that referenced this pull request Feb 24, 2025
@Jericho Jericho added this to the 0.88.0 milestone Feb 24, 2025
@Jericho Jericho added the Enhancement New feature or request label Feb 24, 2025
@Jericho
Copy link
Owner

Jericho commented Feb 24, 2025

🎉 This issue has been resolved in version 0.88.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants