-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for promote/demote channel member to/from admin + Fix serialization bug + Update limits for member invite based on latest zoom api docs #390
Conversation
Fixed Invite member model (api got updated) Updated limits for channel invite, because zoom api got updated
Thanks for submitting this PR. Give me some time to review. The title of your PR will eventually be included in the release notes therefore it's important to be as clear as possible and I'm afraid "Improvements" is quite vague. I thought the title of #389 was much clearer. Speaking of #389, I'm curious: why did you close it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for taking the time to submit this PR.
Source/ZoomNet.IntegrationTests/ZoomNet.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
Source/ZoomNet.IntegrationTests/ZoomNet.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good. Just add the DebuggerBrowsable
to the two model properties we want to hide from developers and this will be ready to be merged.
Thanks again for doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thank you for your contribution.
🎉 This issue has been resolved in version 0.88.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
Added support for promote/demote member + Fixed chat mention bug
Fixed Invite member model (api got updated)
Updated limits for channel invite, because zoom api got updated
Upgraded nugets