This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Feature register multiple with selector tags#3
Open
todoooo wants to merge 2 commits intoJeremyLikness:masterfrom
Open
Feature register multiple with selector tags#3todoooo wants to merge 2 commits intoJeremyLikness:masterfrom
todoooo wants to merge 2 commits intoJeremyLikness:masterfrom
Conversation
Owner
|
Hi, in the spirit of this being a tool for teaching DI I don't want to overly complicate the implementation. I like the changes and have two suggestions ... either (a) fork and release there, or (b) update the README to explain the changes and I will merge here. Thanks for your time and contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change set adds a feature found in .NET, whereby the same type name can be registered multiple times with different tags/selectors, so that a keyed container is returned with the ability to lookup a particular type at runtime.
e.g.
$jsInject.register('WidgetFactory', [() => new WidgetFactoryA()], 'WidgetA');
$jsInject.register('WidgetFactory', [() => new WidgetFactoryB()], 'WidgetB');
var factory = $jsInject.get('WidgetFactory', 'WidgetB');
or
var provider = $jsInject.get('WidgetFactory');
var factory = provider['WidgetB'];