harden shell escaping, path traversal, and prompt injection defenses#248
Merged
JeremyDev87 merged 1 commit intomainfrom Feb 17, 2026
Merged
harden shell escaping, path traversal, and prompt injection defenses#248JeremyDev87 merged 1 commit intomainfrom
JeremyDev87 merged 1 commit intomainfrom
Conversation
…nses - Add 8 shell metacharacters to escapeForShellArg (;|&()<>#) - Add ensureSafePath() for path traversal prevention at input boundary - Add cross-tag delimiter escaping in wrapUserContent/wrapRepoConfiguration - Use crypto.randomUUID() for non-predictable temp filenames - Validate config-derived rules_path before loading
JeremyDev87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
;,|,&,(,),<,>,#) toescapeForShellArg()to prevent command injection via issue labels/author fieldsensureSafePath()function validatingconfig_path,system_prompt_path,rules_pathinputs stay within workspace directorywrapUserContentalso escapes<repository-configuration>tags and vice versa, preventing trust zone breakoutDate.now()withcrypto.randomUUID()for non-guessable temp filenamesrules_pathfrom config file (not just action inputs) before loadingTest plan