add security-engineer as ACT primary agent#578
Merged
JeremyDev87 merged 1 commit intomasterfrom Feb 19, 2026
Merged
Conversation
- Add security-engineer.json agent definition with OWASP Top 10 expertise - Add security.patterns.ts with 21 patterns (EN + KO, confidence 0.90-0.95) - Add security-engineer to ACT_PRIMARY_AGENTS and ACT_AGENT_DISPLAY_INFO - Insert security-engineer at priority 5 in INTENT_PATTERN_CHECKS - Export SECURITY_INTENT_PATTERNS from patterns/index.ts - Add security-engineer to strategy test fixtures and test cases - Add comprehensive tests: 8 prompts + 2 boundary cases in act-agent.strategy - Add security-engineer describe block in primary-agent-resolver.spec.ts - Update agents/README.md with security-engineer entry Closes #564
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #564 | Part of #560
Adds
security-engineeras a new ACT-mode primary agent for implementing security features and fixing vulnerabilities. Previously, security implementation prompts (e.g., "fix SQL injection", "implement JWT auth") fell back tofrontend-developerorbackend-developerwithout proper security expertise context.Changes
New Files
packages/rules/.ai-rules/agents/security-engineer.jsonapps/mcp-server/src/keyword/patterns/security.patterns.tsModified Files
keyword.types.tssecurity-engineertoACT_PRIMARY_AGENTSandACT_AGENT_DISPLAY_INFOintent-pattern-checks.tsplatform-engineer, beforesystems-developer)patterns/index.tsSECURITY_INTENT_PATTERNSstrategy-test.utils.tssecurity-engineertoACT_MODE_AGENTSfixtureact-agent.strategy.spec.tsprimary-agent-resolver.spec.tssecurity-engineerdescribe block (11 prompts + boundary + unavailability fallback)agents/README.mdsecurity-engineerto Quick Reference, Agent Summary, ACT Mode Primary Agents, and file structureAgent Design
Routing Examples
SQL injection 취약점 수정해줘security-engineer✅JWT 인증 구현해줘security-engineer✅XSS 방어 추가해줘security-engineer✅OWASP 준수 구현해줘security-engineer✅인증 서버 개발해줘backend-developer✅ (boundary preserved)보안 검토해줘Mandatory Checklist (8 items)
owasp_top10·input_validation·secrets_management·auth_implementation·dependency_audit·security_configuration·error_handling·logging_no_sensitive_dataTest Results
Progressive test count: 3896 → 3916 → 3920 → 3922 (all green)
Acceptance Criteria
security-engineer.jsoncreated with full role definitionsecurity.patterns.tscreated with comprehensive patterns (EN + KO)security-engineeradded toACT_PRIMARY_AGENTSsecurity-engineeradded toINTENT_PATTERN_CHECKSat priority 5security-engineersecurity-engineersecurity-engineer