Skip to content

add security-engineer as ACT primary agent#578

Merged
JeremyDev87 merged 1 commit intomasterfrom
feat/add-security-engineer-act-primary-agent
Feb 19, 2026
Merged

add security-engineer as ACT primary agent#578
JeremyDev87 merged 1 commit intomasterfrom
feat/add-security-engineer-act-primary-agent

Conversation

@JeremyDev87
Copy link
Owner

Summary

Closes #564 | Part of #560

Adds security-engineer as a new ACT-mode primary agent for implementing security features and fixing vulnerabilities. Previously, security implementation prompts (e.g., "fix SQL injection", "implement JWT auth") fell back to frontend-developer or backend-developer without proper security expertise context.

Note: security-specialist (existing) is an EVAL-mode parallel agent for auditing. security-engineer fills the ACT-mode gap for implementation.

Changes

New Files

File Description
packages/rules/.ai-rules/agents/security-engineer.json Agent definition with OWASP Top 10 expertise, 8 mandatory checklist items
apps/mcp-server/src/keyword/patterns/security.patterns.ts 21 intent patterns (EN + KO), confidence 0.90–0.95

Modified Files

File Change
keyword.types.ts Add security-engineer to ACT_PRIMARY_AGENTS and ACT_AGENT_DISPLAY_INFO
intent-pattern-checks.ts Insert at priority 5 (after platform-engineer, before systems-developer)
patterns/index.ts Export SECURITY_INTENT_PATTERNS
strategy-test.utils.ts Add security-engineer to ACT_MODE_AGENTS fixture
act-agent.strategy.spec.ts Add 8 positive prompts + 2 boundary cases
primary-agent-resolver.spec.ts Add security-engineer describe block (11 prompts + boundary + unavailability fallback)
agents/README.md Add security-engineer to Quick Reference, Agent Summary, ACT Mode Primary Agents, and file structure

Agent Design

Routing Examples

Prompt Routed To
SQL injection 취약점 수정해줘 security-engineer
JWT 인증 구현해줘 security-engineer
XSS 방어 추가해줘 security-engineer
OWASP 준수 구현해줘 security-engineer
인증 서버 개발해줘 backend-developer ✅ (boundary preserved)
보안 검토해줘 EVAL specialist (not ACT) ✅

Mandatory Checklist (8 items)

owasp_top10 · input_validation · secrets_management · auth_implementation · dependency_audit · security_configuration · error_handling · logging_no_sensitive_data

Test Results

3922 tests passed (2 skipped)

Progressive test count: 3896 → 3916 → 3920 → 3922 (all green)

Acceptance Criteria

  • security-engineer.json created with full role definition
  • security.patterns.ts created with comprehensive patterns (EN + KO)
  • security-engineer added to ACT_PRIMARY_AGENTS
  • security-engineer added to INTENT_PATTERN_CHECKS at priority 5
  • Unit test: "JWT 인증 구현해줘" → security-engineer
  • Unit test: "SQL injection 취약점 수정" → security-engineer
  • Unit test: "비밀번호 암호화 추가" → security-engineer
  • No regression in existing tests

- Add security-engineer.json agent definition with OWASP Top 10 expertise
- Add security.patterns.ts with 21 patterns (EN + KO, confidence 0.90-0.95)
- Add security-engineer to ACT_PRIMARY_AGENTS and ACT_AGENT_DISPLAY_INFO
- Insert security-engineer at priority 5 in INTENT_PATTERN_CHECKS
- Export SECURITY_INTENT_PATTERNS from patterns/index.ts
- Add security-engineer to strategy test fixtures and test cases
- Add comprehensive tests: 8 prompts + 2 boundary cases in act-agent.strategy
- Add security-engineer describe block in primary-agent-resolver.spec.ts
- Update agents/README.md with security-engineer entry

Closes #564
@JeremyDev87 JeremyDev87 added feat security sub-issue 상위 이슈의 하위 작업 mcp-server apps/mcp-server labels Feb 19, 2026
@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codingbuddy-landing Ready Ready Preview, Comment Feb 19, 2026 3:15am

@JeremyDev87 JeremyDev87 self-assigned this Feb 19, 2026
@JeremyDev87 JeremyDev87 changed the title feat(agents): add security-engineer as ACT primary agent add security-engineer as ACT primary agent Feb 19, 2026
@JeremyDev87 JeremyDev87 merged commit bc42274 into master Feb 19, 2026
25 checks passed
@JeremyDev87 JeremyDev87 deleted the feat/add-security-engineer-act-primary-agent branch February 19, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat mcp-server apps/mcp-server security sub-issue 상위 이슈의 하위 작업

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(agents): Add security-engineer as ACT primary agent

1 participant