PLAN mode recommended_act_agent ignores intent-based recommendation#363
Merged
JeremyDev87 merged 4 commits intomasterfrom Feb 12, 2026
Merged
PLAN mode recommended_act_agent ignores intent-based recommendation#363JeremyDev87 merged 4 commits intomasterfrom
JeremyDev87 merged 4 commits intomasterfrom
Conversation
…ased resolution When PLAN mode simulates ACT agent recommendation via getActAgentRecommendation(), the project config (primaryAgent) was always returned before intent pattern analysis could run. Add isRecommendation flag to StrategyContext. When true, ActAgentStrategy.resolve() skips project config at priority 3 and moves it to a late fallback after intent patterns and context-based inference. PrimaryAgentResolver and KeywordService pass isRecommendation=true through the resolver chain. Fixes #360
…engineer These agents were previously unreachable via intent pattern analysis in INTENT_PATTERN_CHECKS, only accessible through context-based inference or default fallback. New patterns: - frontend-developer: React, Vue, Angular, Svelte, Next.js, UI components, CSS/Tailwind, responsive design, state management - devops-engineer: GitHub Actions, Jenkins, ArgoCD, Docker, CI/CD pipelines, deployment automation, monitoring Frontend patterns are scoped to web contexts to avoid overlap with mobile-developer patterns. Fixes #360
- Recommendation mode tests: verify isRecommendation skips project config, falls back correctly, respects explicit and recommended agent priorities - Frontend-developer pattern tests: React, Vue.js, UI component, Tailwind, generic frontend prompts - DevOps-engineer pattern tests: GitHub Actions, Jenkins, CI/CD pipeline, Docker, generic devops prompts - Issue #360 scenario tests: design API → backend-developer, build UI → frontend-developer, setup CI/CD → devops-engineer Fixes #360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recommended_act_agentalways returning project config value instead of analyzing prompt intentisRecommendationflag toStrategyContextsoActAgentStrategy.resolve()skips project config priority and uses intent pattern analysis firstfrontend-developer(13 patterns) anddevops-engineer(10 patterns) that were previously unreachable via intent analysisProblem
When
parse_modeis called in PLAN mode,getActAgentRecommendation()simulates ACT mode resolution. However,ActAgentStrategy.resolve()always returned the project config agent (priority 3) before reaching intent pattern analysis (priority 5-11):backend-developeragent-architectfrontend-developeragent-architectdevops-engineeragent-architectSolution
Priority change in recommendation mode
When
isRecommendation=true:Project config→ skippedWhen
isRecommendationis unset/false, existing ACT mode behavior is preserved.New intent patterns
frontend-developer: React, Vue, Angular, Svelte, Next.js, UI components, CSS/Tailwind, responsive design, state managementdevops-engineer: GitHub Actions, Jenkins, ArgoCD, Docker, CI/CD pipelines, deployment automation, monitoringFrontend patterns are scoped to web-specific contexts to avoid overlap with
mobile-developerpatterns.Changed files
resolution-strategy.interface.ts— AddisRecommendation?: booleantoStrategyContextact-agent.strategy.ts— Skip project config whenisRecommendation, add late fallbackprimary-agent-resolver.ts— PassisRecommendationparam throughresolve()keyword.service.ts— PassisRecommendation: trueingetActAgentRecommendation()frontend.patterns.ts— New file with 13 frontend intent patternsdevops.patterns.ts— New file with 10 devops intent patternsintent-pattern-checks.ts— Register frontend and devops patternsTest plan
isRecommendationskips project configFixes #360