Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support product flavors #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yakubbaev
Copy link

Fixes #6

@Jems22
Copy link
Owner

Jems22 commented May 31, 2017

Hi.

Sorry for the delay.

Using this plugin with build variant is a little more complex.
Your pull request works for simple version code declaration (like versionCode 123)
But, it doesn't work for version code based on the default config (eg versionCode 123 + android.defaultConfig.versionCode)

I've updated the plugin, including 2 new params :

  • gradle_file_path: to specify the build.gradle file to modify
  • ext_constant_name: the name of the constant that contains the version code

Maybe you could use thoses param to modify the flavor version code ?
What do you think ?

@phiilu
Copy link

phiilu commented Aug 6, 2019

will this be merged at some point?

@mak12
Copy link

mak12 commented Dec 20, 2019

Any update guys ?

Copy link

@mak12 mak12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested these changes and are working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not support build variants (product flavors)
4 participants