Skip to content

Commit

Permalink
fix(sdk/component): ml_engine deploy version is incorrect type. Fixes k…
Browse files Browse the repository at this point in the history
  • Loading branch information
Justin Hines authored and Jeffwan committed Dec 9, 2020
1 parent 7036217 commit 8851171
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def create_version(model_name, deployemnt_uri=None, version_id=None,
If not set, the default version is '2.7'. Python '3.5' is available
when runtimeVersion is set to '1.4' and above. Python '2.7' works
with all supported runtime versions.
version (str): optional, the payload of the new version.
version (dict): optional, the payload of the new version.
replace_existing (boolean): boolean flag indicates whether to replace
existing version in case of conflict.
wait_interval (int): the interval to wait for a long running operation.
Expand Down Expand Up @@ -210,4 +210,4 @@ def _is_dup_version(self, existing_version):
['description', 'deploymentUri',
'runtimeVersion', 'machineType', 'labels',
'framework', 'pythonVersion', 'autoScaling',
'manualScaling'])
'manualScaling'])
2 changes: 1 addition & 1 deletion components/gcp/ml_engine/deploy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def pipeline(
version_id = '',
runtime_version = '1.10',
python_version = '',
version = '',
version = {},
replace_existing_version = 'False',
set_default = 'True',
wait_interval = '30'):
Expand Down
4 changes: 2 additions & 2 deletions components/gcp/ml_engine/deploy/sample.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
" version_id = '',\n",
" runtime_version = '1.10',\n",
" python_version = '',\n",
" version = '',\n",
" version = {},\n",
" replace_existing_version = 'False',\n",
" set_default = 'True',\n",
" wait_interval = '30'):\n",
Expand Down Expand Up @@ -280,4 +280,4 @@
},
"nbformat": 4,
"nbformat_minor": 2
}
}

0 comments on commit 8851171

Please sign in to comment.