Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature showermax optical #595

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

sudipbhattarai
Copy link
Contributor

Optical properties of shower-max is added and enabled.
PMT Cathode has SD number 7xx16, where xx ranges from 00 (beam right open sector) to 27, stepping clockwise.
The gdml name showermaxgen.gdml is changed to showerMaxDetectorSystem.gdml . This name was used from old showermax, so, basically the file is replaced by the newest showermax model.

@sudipbhattarai
Copy link
Contributor Author

Not ready to merge yet.

@sudipbhattarai
Copy link
Contributor Author

This PR is ready to merge now.

@rakithab
Copy link
Contributor

@rahmans1, is the test geometry falling due to the same issue you mentioned?

@rahmans1
Copy link
Contributor

@rahmans1, is the test geometry falling due to the same issue you mentioned?

Don't think so. This seems to be pointing to a issue with the geometry. I can't see the log for the failure though. So, speculating here. Can you retrigger the workflow?

@rakithab
Copy link
Contributor

I could not find a way to retrigger the workflow, is that something the pull request owner can do?

@rakithab
Copy link
Contributor

@rahmans1 I checked more recent pull requests and some checks are failing due to using the File map_directory/V2U.1a.50cm.parallel.txt which is probably not in use anymore.

@rahmans1
Copy link
Contributor

@rahmans1 I checked more recent pull requests and some checks are failing due to using the File map_directory/V2U.1a.50cm.parallel.txt which is probably not in use anymore.

That is the most recent mapfile for the upstream though. Can you point me to the error log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants