Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification schema doesn't include Override details #51

Open
slominskir opened this issue May 30, 2024 · 0 comments
Open

Notification schema doesn't include Override details #51

slominskir opened this issue May 30, 2024 · 0 comments

Comments

@slominskir
Copy link
Member

The Notification message currently only contains a list of override names:

https://github.com/JeffersonLab/jaws-libp/blob/22fe5ed50483df574be2447bab418e8e450c475e/src/jaws_libp/avro/schemas/EffectiveNotification.avsc

The admin GUI at least needs to know the details of the override (like the comments). This means a separate subscription to the alarm-overrides topic must be used. Might make sense to include the details in the Notification message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant