Avoid duplicate seedfile extension in PWA fit #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the user passed a seedfile with an extension, randomized or parScan fits were given an additional ".txt" extension. Now ".txt" is only added if no extension is provided.
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_sim^seedfile_naming/tests/summary.txt Build log: /work/halld/pull_request_test/halld_sim^seedfile_naming/make_seedfile_naming.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seedfile is treated differently depending on whether single or multiple fits are requested. For example,
fit -c amp.cfg -s my_seedfile.txtwill correctly producemy_seedfile.txtfit -c amp.cfg -s my_seedfile.txt -r 2producesmy_seedfile.txt_0.txtmy_seedfile.txt_1.txtConversely,
fit -c amp.cfg -s my_seedfileproducesmy_seedfilewithout an extension.These commits will add
.txtto the seedfile unless an extension is already in the name and fixes the duplicate extensions bug when running multiple fits.