Kin fit update july19 #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 30, 2019 08:50
…raint equations does not go out of the range (-1,+1) and restore the old constraint equations involving the bending plane, only falling back to the alternate constaints if the arcsin would produce nans. Although the alternate equations do work as far as constraining the vertex is concerned, they lead to strange behavior in the sigmas for the pulls that is not understood at the moment...
…ires and add a parameter for handling the uncertainty near the sense wire to the ccdb database.
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_recon^KinFitUpdateJuly19/tests/summary.txt Build log: /work/halld/pull_request_test/halld_recon^KinFitUpdateJuly19/make_KinFitUpdateJuly19.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts back to the old vertex constraint equations, only using the alternate form if the first version has numerical problems due to the argument to arcsin going out of range. Although the second version of the constraint equations seemed to have the right behaviour for the means of the pulls, the error distributions looked much too narrow for vertex-only fits.