Add features to deal with combinatorics issues properly #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the hybrid/best chisq method.
jrstevenjlab
approved these changes
Aug 2, 2024
Contributor
jrstevenjlab
left a comment
jrstevenjlab
left a comment
There was a problem hiding this comment.
Nice implementation of "hybrid" subtraction of accidental beam photons by sorting combinations for each beam photon by their KinFit chi^2. No change to DSelector library, but provides example code in MakeDSelector template for users to implement in their existing and new DSelectors with minimal changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pre-sorting loop over all combos is added to give an sequence of <ComboIndex, chiSq> pairs with ascending order of ChiSq values, so that later when loop over all combos with certain selection criteria, the first combo survived and filled into the histogram is automatically the combo with the best chiSq. And if the uniqueness tracking on beam photon candidates is used, the combinatorics shall be dealt with in what we called the "hybrid" method (https://halldweb.jlab.org/doc-private/DocDB/ShowDocument?docid=6577).