Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synching ALERT fork with main branch #378

Closed
wants to merge 105 commits into from

Conversation

mpaolone
Copy link
Collaborator

@mpaolone mpaolone commented Dec 2, 2024

No description provided.

efuchey and others added 30 commits February 15, 2024 20:10
It should have been AHDC::adc (since corresponding HitReader also uses this bank), it was AHDC::tdc.
(and stop changing wire number internally to start from zero)
(this requires removing a manual +1 offset for wire number in a perl script in GEMC)
Fix of a merge error after commit f10c09e
PreCluster pairing routine in AHDC ClusterFinder
…r-layer list of hits in AHDC PreCluster

Modified the hardcoded lookup superlayer indices to obtain the geometry parameters to calculate x, y.
Modifications for debugging/validation of index convention change.
@mpaolone mpaolone dismissed baltzell’s stale review January 2, 2025 21:17

The merge-base changed after approval.

@baltzell baltzell disabled auto-merge January 2, 2025 21:18
@baltzell baltzell enabled auto-merge (rebase) January 2, 2025 21:18
baltzell
baltzell previously approved these changes Jan 2, 2025
@mpaolone mpaolone dismissed baltzell’s stale review January 2, 2025 21:23

The merge-base changed after approval.

Copy link
Collaborator

@raffaelladevita raffaelladevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All pending changes have been transformed into issues

raffaelladevita
raffaelladevita previously approved these changes Jan 2, 2025
@baltzell baltzell requested review from whit2333 and removed request for whit2333 January 2, 2025 21:27
baltzell
baltzell previously approved these changes Jan 2, 2025
@mpaolone mpaolone dismissed stale reviews from baltzell and raffaelladevita January 2, 2025 21:29

The merge-base changed after approval.

@baltzell baltzell enabled auto-merge January 2, 2025 21:35
@baltzell baltzell disabled auto-merge January 2, 2025 21:35
@baltzell baltzell enabled auto-merge (rebase) January 2, 2025 21:35
baltzell
baltzell previously approved these changes Jan 2, 2025
@mpaolone mpaolone dismissed baltzell’s stale review January 2, 2025 21:36

The merge-base changed after approval.

@baltzell baltzell self-requested a review January 2, 2025 21:39
@baltzell
Copy link
Collaborator

baltzell commented Jan 2, 2025

closing just to workaround github bug ...

@baltzell baltzell closed this Jan 2, 2025
auto-merge was automatically disabled January 2, 2025 21:40

Pull request was closed

@baltzell baltzell mentioned this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants