Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #841 : replace isEqualNode by strict equality #889

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Fix for #841 : replace isEqualNode by strict equality #889

merged 1 commit into from
Apr 26, 2016

Conversation

abalhier
Copy link
Contributor

Fix for #841 IsEqualNode is not available in IE8 and cannot be shimmed.

@kurttheviking
Copy link

fwiw: Our team forked react-select internally then applied this patch; I can confirm everything is working as expected

IsEqualNode is not available in IE8 and cannot be shimmed.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.889% when pulling cd2372f on abalhier:replace_is_equal_node_by_strict_equality into 1787a7e on JedWatson:master.

@abalhier
Copy link
Contributor Author

Same for us. It works from IE8 to IE11. No regression observed on multiple versions of Chrome and FF (tested on our app via Browserstack).

@JedWatson
Copy link
Owner

Thanks @abalhier and @kurttheviking for verifying!

@JedWatson JedWatson merged commit bd55d8f into JedWatson:master Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants