Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with value object not being passed to handleRequired #847

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Fix issue with value object not being passed to handleRequired #847

merged 1 commit into from
Apr 26, 2016

Conversation

andyhite
Copy link

I discovered that my previous patch for required was failing in some cases (for instance, in Internet Explorer) but passing in others for some reason, so this PR addresses that issue. The problem was that the value being passed to handleRequired was the value directly from this.props.value instead of the expanded value object, which handleRequired expects.

Don't ask me how this ever worked at all, haha.

This PR also fixes the same issue with the original handleRequired implementation on getDefaultState, and removes the props-in-getDefaultState anti-pattern.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6939cb2 on RealHQ:master into * on JedWatson:master*.

@JedWatson
Copy link
Owner

Thanks for that @andyhite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants