Fix issue with value object not being passed to handleRequired #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 6939cb2 on RealHQ:master into * on JedWatson:master*. |
|
Thanks for that @andyhite! |
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that my previous patch for
requiredwas failing in some cases (for instance, in Internet Explorer) but passing in others for some reason, so this PR addresses that issue. The problem was that the value being passed tohandleRequiredwas the value directly fromthis.props.valueinstead of the expanded value object, whichhandleRequiredexpects.Don't ask me how this ever worked at all, haha.
This PR also fixes the same issue with the original
handleRequiredimplementation ongetDefaultState, and removes the props-in-getDefaultState anti-pattern.