Skip to content

feat: add aria describedby attribute to props #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add aria describedby attribute to props #5563

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e74f5b
feat: add aria describedby attribute to props
aakashsigdel Feb 16, 2023
3ca1540
fix: format with prettier
aakashsigdel Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react-select/src/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ export interface Props<
'aria-labelledby'?: AriaAttributes['aria-labelledby'];
/** Used to set the priority with which screen reader should treat updates to live regions. The possible settings are: off, polite (default) or assertive */
'aria-live'?: AriaAttributes['aria-live'];
/** HTML ID of an element that should be used as a description */
'aria-describedby'?: AriaAttributes['aria-describedby'];
/** Customise the messages used by the aria-live component */
ariaLiveMessages?: AriaLiveMessages<Option, IsMulti, Group>;
/** Focus the control when it is mounted */
Expand Down Expand Up @@ -1638,6 +1640,9 @@ export default class Select<
: {
'aria-describedby': this.getElementId('placeholder'),
}),
...(!!this.props['aria-describedby'] && {
'aria-describedby': this.props['aria-describedby'],
}),
};

if (!isSearchable) {
Expand Down