-
Notifications
You must be signed in to change notification settings - Fork 4.2k
add aria-required attribute to select #5014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aria-required attribute to select #5014
Conversation
if aria-required is passed to the select component, it is not drilled to the input element. This update adds it to the props of select. Fixes #5006
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 10c48de:
|
|
hello @Methuselah96 I was wondering if its possible to see this pr reviewed? It would be very helpful for our screen reader users |
|
|
@imanpalsingh thanks for the PR! are there any updates on getting this merged? |
|
@Rall3n Any objections? |
|
@Methuselah96 I added Would need some editing if we merged both, but I think the ability to set |
@SimonSelg @Methuselah96 @Rall3n Let me know if you meant something else |
|
Looks like after #4882 this won't be required. This PR almost turned an year old, adios |
Description
if
aria-requiredis passed to the select component, it is not drilled to the input element. This update adds it to the props ofSelectcomponentThis
will result in
For issue : #5006