Skip to content

Conversation

@imanpalsingh
Copy link

@imanpalsingh imanpalsingh commented Jan 19, 2022

Description

if aria-required is passed to the select component, it is not drilled to the input element. This update adds it to the props of Select component

This

<Select
    options={options}
    aria-required={true}
  />

will result in

<input aria-required="true  ... />

For issue : #5006

if aria-required is passed to the select component, it is not drilled to the input element. This update adds it to the props of select.

Fixes #5006
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 10c48de:

Sandbox Source
react-codesandboxer-example Configuration

@adamrparsons
Copy link

hello @Methuselah96 I was wondering if its possible to see this pr reviewed? It would be very helpful for our screen reader users

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2022

⚠️ No Changeset found

Latest commit: 10c48de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SimonSelg
Copy link

@imanpalsingh thanks for the PR! are there any updates on getting this merged?

@Methuselah96
Copy link
Collaborator

@Rall3n Any objections?

@Rall3n
Copy link
Contributor

Rall3n commented Oct 5, 2022

@Methuselah96 I added aria-required as part of the required PR.

Would need some editing if we merged both, but I think the ability to set aria-required separately should be added.

@imanpalsingh
Copy link
Author

Would need some editing if we merged both

@SimonSelg @Methuselah96 @Rall3n
I have resolved the merge conflicts.

Let me know if you meant something else

@imanpalsingh
Copy link
Author

imanpalsingh commented Nov 4, 2022

Looks like after #4882 this won't be required. This PR almost turned an year old, adios

@imanpalsingh imanpalsingh deleted the fix-aria-required-not-passed branch November 4, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants