Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input doesn't auto size on safari in development env #4854

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

quanphm
Copy link
Contributor

@quanphm quanphm commented Oct 10, 2021

This fixes issue #4839 . The bug comes from @emotion when start react-select in development env.

This fix will recompute the css of input container whenever value changes. To not break the layout, I just add transform property. I've checked the profiler and the number of re-render times was the same as react-select@5.1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2021

🦋 Changeset detected

Latest commit: b8e3447

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8e3447:

Sandbox Source
react-codesandboxer-example Configuration

@quanphm
Copy link
Contributor Author

quanphm commented Oct 12, 2021

@Methuselah96 @ebonow Can you review this PR? I don't think emotion will fix this bug anytime soon so we have to patch the bug from our end.

@ebonow
Copy link
Collaborator

ebonow commented Oct 13, 2021

@mikunpham Thanks for being so communicative and timely on this issue. I will bring up this PR during our next collaborator meeting tomorrow as a patch candidate.

@ebonow ebonow added this to the 5.2 milestone Oct 13, 2021
@JedWatson
Copy link
Owner

Thanks @mikunpham

@JedWatson JedWatson merged commit 564a143 into JedWatson:master Oct 14, 2021
@quanphm quanphm deleted the fix/issue-4839 branch October 15, 2021 03:04
@quanphm
Copy link
Contributor Author

quanphm commented Oct 15, 2021

Thanks @ebonow @JedWatson for approving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Letters is not showing at all in Safari on iOS when using react-select 5.1.0
3 participants