-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: input doesn't auto size on safari in development env #4854
Conversation
🦋 Changeset detectedLatest commit: b8e3447 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b8e3447:
|
7796262
to
b8e3447
Compare
@Methuselah96 @ebonow Can you review this PR? I don't think |
@mikunpham Thanks for being so communicative and timely on this issue. I will bring up this PR during our next collaborator meeting tomorrow as a patch candidate. |
Thanks @mikunpham |
Thanks @ebonow @JedWatson for approving this. |
This fixes issue #4839 . The bug comes from
@emotion
when start react-select in development env.This fix will recompute the css of input container whenever value changes. To not break the layout, I just add
transform
property. I've checked the profiler and the number of re-render times was the same as react-select@5.1.0