[3739] Use custom DownChevron and CrossIcon when supplied #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 691f355 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 691f355:
|
jkbmat
force-pushed
the
use-custom-downchevron-crossicon-3739
branch
from
75f335c
to
e7a3fcd
Compare
bladey
added
the
pr/needs-review
bladey
added
pr/enhancement
|
See comment in #3739 |
Methuselah96
requested changes
Jan 16, 2021
| }: MultiValueRemoveProps) { | ||
| const CrossIcon = useMemo(() => defaultComponents({ components }).CrossIcon, [components]); |
There was a problem hiding this comment.
Instead of calling defaultComponents here (and the other two places), can we instead pass down the components like we do for MultiValue here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3739