Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3739] Use custom DownChevron and CrossIcon when supplied #3959

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jkbmat
Copy link

@jkbmat jkbmat commented Mar 3, 2020

Fixes #3739

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2020

🦋 Changeset is good to go

Latest commit: 691f355

We got this.

This PR includes changesets to release 1 package
Name Type
react-select Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 691f355:

Sandbox Source
react-codesandboxer-example Configuration

@jkbmat jkbmat force-pushed the use-custom-downchevron-crossicon-3739 branch from 75f335c to e7a3fcd Compare March 3, 2020 09:42
@bladey bladey added the pr/needs-review PRs that need to be reviewed to determine outcome label May 26, 2020
@bladey bladey added pr/enhancement PRs that are specifically enhancing the project and removed category/enhancement labels Jun 24, 2020
@bladey
Copy link
Contributor

bladey commented Jul 8, 2020

Hi @jkbmat,

Thanks for the PR, while this now enables both icons to be customised, it is already possible to do so - see issue #3739 for more details.

If I'm missing something, please let me know!

@bladey bladey closed this Jul 8, 2020
@bladey bladey reopened this Jul 16, 2020
@bladey
Copy link
Contributor

bladey commented Jul 16, 2020

See comment in #3739

}: MultiValueRemoveProps) {
const CrossIcon = useMemo(() => defaultComponents({ components }).CrossIcon, [components]);
Copy link
Collaborator

@Methuselah96 Methuselah96 Jan 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling defaultComponents here (and the other two places), can we instead pass down the components like we do for MultiValue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/enhancement PRs that are specifically enhancing the project pr/needs-review PRs that need to be reviewed to determine outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providing DownChevron in components doesn't work
3 participants