Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autoComplete as prop to the Select component #3666

Closed
wants to merge 4 commits into from

Conversation

lvl99
Copy link

@lvl99 lvl99 commented Jul 5, 2019

As mentioned in issue #3500 and #2395 and having my own need to set an explicit autoComplete value (namely to prevent Google Chrome from showing its autofill drop-down on top of the react-select drop-down) I've attempted a quick simple fix.

@Shperung
Copy link

In which version of the library are these changes?

@lvl99
Copy link
Author

lvl99 commented Jul 12, 2019

@Shperung whatever was on master?

@lvl99
Copy link
Author

lvl99 commented Jul 18, 2019

@JedWatson any view whether this is in the right direction, or acceptable or not as is?

@lvl99
Copy link
Author

lvl99 commented Jul 30, 2019

Bump

@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome enhancement and removed uncertain labels Jun 4, 2020
@bladey bladey added pr/enhancement PRs that are specifically enhancing the project and removed category/enhancement labels Jun 24, 2020
@bladey
Copy link
Contributor

bladey commented Jul 2, 2020

Resolved conflicts and created new PR #4105, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/enhancement PRs that are specifically enhancing the project pr/needs-review PRs that need to be reviewed to determine outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants