add autoComplete as prop to the Select component #3666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In which version of the library are these changes? |
|
@Shperung whatever was on |
|
@JedWatson any view whether this is in the right direction, or acceptable or not as is? |
|
Bump |
bladey
added
pr/needs-review
bladey
added
pr/enhancement
|
Resolved conflicts and created new PR #4105, closing. |
This was referenced Sep 12, 2021
This was referenced May 13, 2022
This was referenced May 13, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #3500 and #2395 and having my own need to set an explicit
autoCompletevalue (namely to prevent Google Chrome from showing its autofill drop-down on top of thereact-selectdrop-down) I've attempted a quick simple fix.