handle options with value 0 properly #1310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaglietto
reviewed
Oct 23, 2016
| @@ -553,7 +553,7 @@ const Select = React.createClass({ | |||
| * @param {Object} nextProps - optionally specify the nextProps so the returned array uses the latest configuration | |||
| * @returns {Array} the value of the select represented in an array | |||
| */ | |||
| getValueArray (value, nextProps) { | |||
| getValueArray (value, nextProps = undefined) { | |||
There was a problem hiding this comment.
Why is this needed? is not the default behaviour?
There was a problem hiding this comment.
Yes you're right, but my IDE was warning me that this function was sometimes called with only 1 argument. I thought making it explicit wouldn't hurt.
There was a problem hiding this comment.
This param being optional should be indicated in the jsdoc http://usejsdoc.org/tags-param.html#optional-parameters-and-default-values, which should also stop the IDE warning
|
Nice it looks good to me, I agree that 0 it a possible value should not be consider as empty 👍 |
|
Is this going to be merged any time soon? |
|
No merged PRs since mid-november? Would really like this one to land :/ |
|
It would be great to get this merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1284