Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #546. Added support for boolean values. #1224

Merged
merged 1 commit into from
Sep 17, 2016

Conversation

Aaronius
Copy link
Contributor

@Aaronius Aaronius commented Sep 16, 2016

Fixes #546. This adds support for boolean values but suffers one issue that also exists with numeric values: If you go to the live demo and in the Numeric Values example you select "Multi-select" you'll notice you can't select values. This is due to the select having the simpleValue prop and this line which converts the numeric values into a string. The same thing happens with booleans and it fouls up the selection process for multi-select when simpleValue is enabled.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.216% when pulling e3fb016 on Aaronius:boolean-values into 15d0bb8 on JedWatson:master.

@JedWatson
Copy link
Owner

Nice work @Aaronius!

Sounds like we need to do some work around how simpleValue works with numbers and booleans, but in the meantime this change is good 👍

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants