Fixed #546. Added support for boolean values. #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @Aaronius! Sounds like we need to do some work around how simpleValue works with numbers and booleans, but in the meantime this change is good 👍 Thanks! |
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546. This adds support for boolean values but suffers one issue that also exists with numeric values: If you go to the live demo and in the Numeric Values example you select "Multi-select" you'll notice you can't select values. This is due to the select having the
simpleValueprop and this line which converts the numeric values into a string. The same thing happens with booleans and it fouls up the selection process for multi-select whensimpleValueis enabled.