Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When clicked fast enough, component throws error like "cannot call function focus() of undefined" #208

Closed
voroshkov opened this issue May 25, 2015 · 2 comments
Closed

When clicked fast enough, component throws error like "cannot call function focus() of undefined" #208

voroshkov opened this issue May 25, 2015 · 2 comments
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer
Milestone
0.5.1

Comments

@voroshkov
Copy link

I found this issue during writing tests with React.TestUtils.
The issue is annoying, but the solution is simple:
in ComponentDidUpdate you must add clearTimeout(this._focusTimeout) before overwriting this._focusTimeout variable with new timeout id.
@dcousens
Copy link
Collaborator

@voroshkov can you please add a PR?

@dcousens dcousens added the issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer label May 27, 2015
@dcousens dcousens added this to the 0.4.10 milestone May 27, 2015
@jorrit jorrit mentioned this issue Sep 11, 2015
Closed
PetrGlad added a commit to PetrGlad/react-select that referenced this issue Sep 25, 2015
@PetrGlad
Fix for JedWatson#208. Reset timeout before setting new one.
171781d
JedWatson added a commit that referenced this issue Sep 30, 2015
@JedWatson
Merge pull request #481 from PetrGlad/pg-jw-208
98372c4 
Fix for #208 and #434. Reset timeout before setting new one.
@jochenberger
Copy link
Contributor

I think that this can be closed since #481 was merged.

@jossmac jossmac closed this as completed Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer
Projects
None yet
Milestone
0.5.1
Development

No branches or pull requests
4 participants
@jochenberger @dcousens @jossmac @voroshkov