improve autoComplete behaviour

JedWatson · Dec 21, 2017 · fc35f69 · fc35f69
1 parent 81d5d46
commit fc35f69
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/src/Select.js b/src/Select.js
@@ -95,6 +95,9 @@ class Select extends React.Component {
 		if (this.props.autoFocus || this.props.autofocus) {
 			this.focus();
 		}
+		if (this.props.autoComplete && this.props.multi) {
+			console.warn('Warning: To enable autoComplete the prop "multi" must be set to "false".');
+		}
 		if (this.isAutoCompleteEnabled()) {
 			this.addAutoFillListener();
 		}
@@ -403,12 +406,9 @@ class Select extends React.Component {
 	}
 
 	handleHiddenInputChange (e) {
-		const hasValue = this.getValueArray(this.props.value).length;
-		if (!hasValue) {
-			this.selectValue({ value: e.target.value });
-			// basically a change event on the hidden field means the autoComplete function of the browser was used
-			this.setAutofilled();
-		}
+		this.selectValue({ value: e.target.value });
+		// basically a change event on the hidden field means the autoComplete function of the browser was used
+		this.setAutofilled();
 	}
 
 
@@ -835,9 +835,7 @@ class Select extends React.Component {
 					onClick={onClick}
 					value={valueArray[0]}
 				>
-					{ !this.state.inputValue &&
-						renderLabel(valueArray[0])
-					}
+					{ renderLabel(valueArray[0]) }
 				</ValueComponent>
 			);
 		}
@@ -1035,7 +1033,7 @@ class Select extends React.Component {
 
 	renderHiddenField (valueArray) {
 		const hasValue = this.getValueArray(this.props.value).length;
-		const useAutoComplete = this.isAutoCompleteEnabled() && !hasValue;
+		const useAutoComplete = this.isAutoCompleteEnabled();
 
 		if (!this.props.name) return;
 		if (!this.props.multi || this.props.joinValues) {