Skip to content

Commit

Permalink
Select component passes its :menuRenderer duplicate :onSelect and :se…
Browse files Browse the repository at this point in the history
…lectValue values (not sure why). Creatable only override :onSelect (whoops). This caused a bug downstream in react-virtualized-select. That bug has been fixed, but in order to prevent further confusion, this PR overrides both properties.
  • Loading branch information
Brian Vaughn committed Nov 18, 2016
1 parent ad337ee commit ab82015
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Creatable.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ const Creatable = React.createClass({

return menuRenderer({
...params,
onSelect: this.onOptionSelect
onSelect: this.onOptionSelect,
selectValue: this.onOptionSelect
});
},

Expand Down

0 comments on commit ab82015

Please sign in to comment.