Fixed a bug in CodeMirror component lifecycle #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I expect to happen: * first componentWillUpdate is called, such that old and new props are * different * then render() is called with the new props, if componentShouldUpdate * is true. What actually happens: * first render() is called with the new props. * then componentWillUpdate is called such that old and new props are the * same. This is because debounce is deferring execution of componentWillReceiveProps, thus breaking react component lifecycle (which is described here: https://busypeoples.github.io/post/react-component-lifecycle/).
|
@jbeard4 This library is pretty much abandoned. Have you've glimpsed at the plethora of issues? I wrote react-codemirror2 and have been actively maintaining it because of the frustrations I've encountered here. Not to mention the lack of tests, heavy dependencies, ancient documentation, etc. I am shocked people are still grasping on to this library... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I expect to happen:
What actually happens:
This is because debounce is deferring execution of
componentWillReceiveProps, thus breaking react component lifecycle
(which is described here:
https://busypeoples.github.io/post/react-component-lifecycle/).