test: remove orphaned git_repo fixture and test_utils from .rhiza/tests - #877
Merged
Conversation
The git_repo fixture (and its MOCK_MAKE_SCRIPT / MOCK_UV_SCRIPT mock scripts) became dead code when its only consumer, .rhiza/tests/test_git_repo_fixture.py, was deleted in #876. Drop the fixture, the mock scripts, and the now-unused GIT/os/shutil/ subprocess imports. Keep the still-used root and logger session fixtures and refresh the module docstring accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
test_utils.py became fully unused: its run_make/strip_ansi/ setup_rhiza_git_repo helpers lost their consumer when test_git_repo_fixture.py was deleted in #876, and its GIT export lost its last user when the git_repo fixture was removed in the previous commit. No test module imports it any longer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes dead test scaffolding from the synced .rhiza/tests/ suite in jquantstats, following the earlier removal of the only consumer of the git_repo fixture.
Changes:
- Deleted
.rhiza/tests/test_utils.py(previously contained shared helper utilities). - Simplified
.rhiza/tests/conftest.pyby removing the unusedgit_repofixture and its mock-script helpers, leaving only the session fixtures (root,logger).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .rhiza/tests/conftest.py | Removes unused git_repo fixture + related helpers/imports; keeps root/logger. |
| .rhiza/tests/test_utils.py | Deletes now-orphaned shared test utilities module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
3
to
+6
| This file and its associated tests flow down via a SYNC action from the jebel-quant/rhiza repository | ||
| (https://github.com/jebel-quant/rhiza). | ||
|
|
||
| Provides test fixtures for testing git-based workflows and version management. | ||
| Provides shared session-scoped fixtures (``root`` and ``logger``) used across the test modules. |
The .rhiza/tests/stress/ directory held only scaffolding (conftest with
--iterations/--workers options + fixtures, __init__, README) and no
stress tests. The `make stress` target operates on ${TESTS_FOLDER}/stress
(tests/stress), not this directory, so nothing referenced it.
Also refresh .rhiza/tests/README.md, which was stale: it still documented
test_git_repo_fixture.py, test_utils.py, the git_repo fixture, and the
stress folder — all now removed from this repo.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes now-dead test scaffolding from
.rhiza/tests/:conftest.py: drop thegit_repofixture and itsMOCK_MAKE_SCRIPT/MOCK_UV_SCRIPThelpers, plus the now-unusedGIT/os/shutil/subprocessimports. Keep the still-usedrootandloggersession fixtures.test_utils.py: deleted — nothing imports it any longer.Why
The
git_repofixture's only consumer,.rhiza/tests/test_git_repo_fixture.py, was deleted in #876. That left the fixture, its mock scripts, andtest_utils.py(whoseGITexport the fixture used; its other helpers lost their consumer with the same deletion) as dead code.Note on the SYNC template
.rhiza/tests/flows down from jebel-quant/rhiza via SYNC, so this is a local stopgap. The matching upstream fix — relocating thegit_repofixture into rhiza's own suite so it stops shipping to consumers — is Jebel-Quant/rhiza#1389. Once that merges, the next sync produces the same result.Verification
.rhiza/testssuite: 34 passed.🤖 Generated with Claude Code