Update Ecobee definitions#548
Open
sirwolfgang wants to merge 1 commit intoJc2k:mainfrom
Open
Conversation
…n for scheduled event time
1c9e4fd to
2a1fbc1
Compare
Collaborator
|
Please explain the history and how the the existing ones were incorrect |
Author
|
@bdraco I don't understand how I can explain the history, I didn't create the first version. The diff shows how they were swapped. |
Collaborator
Unfortunately without understanding why they were set to the UUIDs currently in use, I can't merge this PR because I don't know if its going to break older/different models. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates and expands the Ecobee-specific characteristic definitions in
characteristic_types.py. The main changes include correcting UUID assignments for several thermostat characteristics, improving documentation for scheduled change time handling, and adding new characteristics for equipment status and SmartSensor data.Updates to Ecobee characteristic UUIDs and documentation:
VENDOR_ECOBEE_NEXT_SCHEDULED_CHANGE_TIME, including details on value formats, meaning, and correct write behavior for timed holds.New Ecobee characteristic definitions: