Skip to content

**DO NOT MERGE** Set sensible COAP timeouts for sleepy thread devices#260

Draft
Jc2k wants to merge 9 commits intomainfrom
homekit_controller_coap_sleepy
Draft

**DO NOT MERGE** Set sensible COAP timeouts for sleepy thread devices#260
Jc2k wants to merge 9 commits intomainfrom
homekit_controller_coap_sleepy

Conversation

@Jc2k
Copy link
Copy Markdown
Owner

@Jc2k Jc2k commented Dec 1, 2022

Some Thread devices are sleepy - CoAP packets queue at routers. They are then delivered when the device wakes up.

In some cases the default sleep intervals are longer that the default CoAP timeouts. Upstream added TransportTuning for us, which lets us avoid timeouts (timeouts cause retries etc).

For a CoAP pairing where we have an Accessory Runtime Information service and a Sleep Interval characteristic, set the ACK timeout based on that interval.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (5d8c8f1) 74.47% compared to head (f7061e6) 74.41%.

Files Patch % Lines
aiohomekit/controller/coap/connection.py 23.52% 13 Missing ⚠️
aiohomekit/controller/coap/pairing.py 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   74.47%   74.41%   -0.06%     
==========================================
  Files          99       99              
  Lines        9331     9353      +22     
==========================================
+ Hits         6949     6960      +11     
- Misses       2382     2393      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant